mirror of
https://github.com/PrismLauncher/PrismLauncher.git
synced 2026-06-29 01:54:20 +03:00
chore: add TODO for potential future race condition
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
This commit is contained in:
parent
9f94b00925
commit
6f0e053f4d
1 changed files with 3 additions and 0 deletions
|
|
@ -173,6 +173,9 @@ LaunchDecision LaunchController::decideLaunchMode()
|
|||
ProgressDialog progDialog(m_parentWidget);
|
||||
progDialog.setSkipButton(true, tr("Abort"));
|
||||
|
||||
// TODO: this relies on tasks' synchronous signal dispatching nature
|
||||
// TODO: meaning currentTask can't complete and become null while this code is running
|
||||
// TODO: this code will produce a race condition when tasks become fully async
|
||||
auto task = accountToCheck->currentTask();
|
||||
progDialog.execWithTask(task.get());
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue