From 6f0e053f4d881e8a390b2e3613221f8f0a4cc144 Mon Sep 17 00:00:00 2001 From: Octol1ttle Date: Thu, 5 Feb 2026 11:15:40 +0500 Subject: [PATCH] chore: add TODO for potential future race condition Signed-off-by: Octol1ttle --- launcher/LaunchController.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/launcher/LaunchController.cpp b/launcher/LaunchController.cpp index 2221158fb..d0cd64e51 100644 --- a/launcher/LaunchController.cpp +++ b/launcher/LaunchController.cpp @@ -173,6 +173,9 @@ LaunchDecision LaunchController::decideLaunchMode() ProgressDialog progDialog(m_parentWidget); progDialog.setSkipButton(true, tr("Abort")); + // TODO: this relies on tasks' synchronous signal dispatching nature + // TODO: meaning currentTask can't complete and become null while this code is running + // TODO: this code will produce a race condition when tasks become fully async auto task = accountToCheck->currentTask(); progDialog.execWithTask(task.get());