This commit aims to fix all clang-analyzer-* warnings from clang-tidy.
Here is the list of the ones found in project:
"clang-analyzer-core.uninitialized.UndefReturn",
"clang-analyzer-deadcode.DeadStores",
"clang-analyzer-optin.core.EnumCastOutOfRange",
Some exceptions:
clang-analyzer-cplusplus.NewDeleteLeaks -> may need to disable it as
is a false positive
clang-analyzer-optin.cplusplus.VirtualCall -> may need to disable it
(or refactor a bunch of code to drop the virtual from those functions)
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
This allows us to directly access a page from outside. This will be
useful for telling the ManagedPackPage who is the window it's on, so
that we can close it when updating :^)
Signed-off-by: flow <flowlnlnln@gmail.com>