Trial97
6699d3eca0
clang-tidy: clang-analyzer-*
...
This commit aims to fix all clang-analyzer-* warnings from clang-tidy.
Here is the list of the ones found in project:
"clang-analyzer-core.uninitialized.UndefReturn",
"clang-analyzer-deadcode.DeadStores",
"clang-analyzer-optin.core.EnumCastOutOfRange",
Some exceptions:
clang-analyzer-cplusplus.NewDeleteLeaks -> may need to disable it as
is a false positive
clang-analyzer-optin.cplusplus.VirtualCall -> may need to disable it
(or refactor a bunch of code to drop the virtual from those functions)
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2026-05-13 10:20:26 +03:00
Trial97
464a04a2cb
ensure that save lock isunlocked on success
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2026-03-10 09:26:30 +02:00
Alexandru Ionut Tripon
6809d46ab6
remove followSymlinks calls ( #4650 )
2026-01-30 13:10:26 +02:00
Octol1ttle
584dc47da5
chore: remove double spaces from logs
...
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
2026-01-29 19:15:27 +05:00
Trial97
e5aa5e298f
remove followSymlinks calls
...
most probably they were used incorectly anyway
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2026-01-17 17:31:51 +02:00
Alexandru Ionut Tripon
2e8256e322
fix ftb import for old packs ( #4787 )
2026-01-17 17:03:59 +02:00
Trial97
3496b7b3a0
fix ftb import for old packs
...
fixes #4786
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2026-01-17 01:22:25 +02:00
Octol1ttle
c24fd2f570
refactor(instance creation): use RAII lock to suspend instance settings saving
...
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
2026-01-11 21:00:04 +05:00
Octol1ttle
549405ab2f
refactor!!!: migrate from shared pointers
...
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
2026-01-11 21:00:03 +05:00
Trial97
53acc60983
format the code
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2026-01-09 22:28:25 +02:00
Edvin Bryntesson
9e614f94cd
fix FTBA instance loading
...
Signed-off-by: Edvin Bryntesson <epost@edvinbryntesson.se>
2025-11-24 13:33:54 +01:00
TheKodeToad
e42c9d2a1d
Remove ensure JSON helpers
...
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
2025-11-09 21:35:11 +00:00
Marco von Rosenberg
182d130c18
fix: prioritize .ftbapp/version.json in FTB App import
...
Newer versions of FTB App create a stub version.json in the instance
root with only a comment directing to .ftbapp/version.json. The old
logic would find this stub file first and fail to parse it, causing
modpacks to not be detected.
This fix checks .ftbapp/version.json first (newer location) before
falling back to the root version.json (older location).
Signed-off-by: Marco von Rosenberg <codingmarco@gmail.com>
2025-10-06 21:56:19 +09:00
moehreag
100b209043
Add Ornithe, LegacyFabric and Rift mod loader filters
...
Signed-off-by: moehreag <moehreag@gmail.com>
2025-08-05 11:12:22 +02:00
Trial97
f40117b431
update ftb import to consider meta folder
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2025-07-27 14:59:02 +03:00
matthewperiut
20a833e1b9
Add "Babric" and "Babric (BTA)" as shown on Modrinth. Add "Show More" button to allow for space efficiency and readiness to add all other Modrinth modloader types.
...
Signed-off-by: matthewperiut <matthewperiut@gmail.com>
2025-07-10 11:12:27 -04:00
TheKodeToad
9c942c6894
Fix CurseForge support
...
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
2025-03-26 23:35:40 +00:00
chouzz
92113e233a
Add totalTimePlayed for FTBApp import
...
Signed-off-by: chouzz <zhouhua852@gmail.com>
2024-03-09 19:36:40 +08:00
TheKodeToad
f54ac25614
Use minecraft instead of .minecraft for better accessibility
...
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
2024-01-21 02:28:55 +00:00
LocalSpook
5be80df1ee
Replace typedef with using
...
Signed-off-by: LocalSpook <56512186+LocalSpook@users.noreply.github.com>
2023-10-24 01:36:27 -07:00
Trial97
4704c522e0
moved modloaderTypes to ModPlatform
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2023-08-23 10:26:57 +03:00
Sefa Eyeoglu
aac734d174
fix: add theoretical support for NeoForge in FTB modpacks
...
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-08-17 22:21:12 +02:00
Trial97
ef21879df4
replaced require with ensure for jvmArgs
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2023-07-21 19:30:00 +03:00
Trial97
7befd63cce
fixed settings
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2023-07-15 00:28:58 +03:00
Alexandru Ionut Tripon
2c2c39b42c
Update launcher/modplatform/import_ftb/PackInstallTask.cpp
...
Co-authored-by: TheKodeToad <TheKodeToad@proton.me>
Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
2023-07-15 00:17:48 +03:00
Alexandru Ionut Tripon
0692cbe701
Update launcher/modplatform/import_ftb/PackInstallTask.cpp
...
Co-authored-by: TheKodeToad <TheKodeToad@proton.me>
Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
2023-07-15 00:17:32 +03:00
Trial97
bd6e8533ad
send by reference
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2023-07-13 19:58:08 +03:00
Trial97
843c2d67eb
Added FTBAPP Import
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
2023-07-13 18:41:29 +03:00