From f3495bc4c011be93708d2d871bedaccaa930fe18 Mon Sep 17 00:00:00 2001 From: Alexandru Ionut Tripon Date: Thu, 20 Nov 2025 09:27:45 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: TheKodeToad Signed-off-by: Alexandru Ionut Tripon --- launcher/minecraft/mod/ModFolderModel.cpp | 2 +- launcher/ui/pages/instance/ModFolderPage.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/launcher/minecraft/mod/ModFolderModel.cpp b/launcher/minecraft/mod/ModFolderModel.cpp index d711fe0e5..db22bec89 100644 --- a/launcher/minecraft/mod/ModFolderModel.cpp +++ b/launcher/minecraft/mod/ModFolderModel.cpp @@ -429,7 +429,7 @@ bool ModFolderModel::setResourceEnabled(const QModelIndexList& indexes, EnableAc QString yesButton; if (requiredToEnable.size() > 0 && requiredToDisable.size() > 0) { title = tr("Confirm toggle"); - message = tr("Toggling this mod(s) will cause changes to other mods.\n") + + message = tr("Toggling these mod(s) will cause changes to other mods.\n") + tr("%n mod(s) will be enabled\n", "", requiredToEnable.size()) + tr("%n mod(s) will be disabled\n", "", requiredToDisable.size()) + tr("Do you want to automatically apply these related changes?\nIgnoring them may break the game."); diff --git a/launcher/ui/pages/instance/ModFolderPage.cpp b/launcher/ui/pages/instance/ModFolderPage.cpp index 8ea2b7be8..369b9a87d 100644 --- a/launcher/ui/pages/instance/ModFolderPage.cpp +++ b/launcher/ui/pages/instance/ModFolderPage.cpp @@ -142,7 +142,7 @@ void ModFolderPage::removeItems(const QItemSelection& selection) auto affected = m_model->getAffectedMods(indexes, EnableAction::DISABLE); if (!affected.isEmpty()) { auto response = CustomMessageBox::selectable(this, tr("Confirm Disable"), - tr("The mods you are tring to disable are required by %1 mods.\n" + tr("The mods you are trying to delete are required by %1 mods.\n" "Do you want to disable them?") .arg(affected.length()), QMessageBox::Warning, QMessageBox::Yes | QMessageBox::No, QMessageBox::No)