mc-in-work/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2026-07-01 19:06:58 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor!!!: migrate from shared pointers

Browse source 
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
(cherry picked from commit 549405ab2f)
This commit is contained in:
Octol1ttle 2026-01-07 19:16:54 +05:00 • committed by Trial97
parent 7755e0def9
commit e89ce1124a
No known key found for this signature in database
GPG key ID: 55EF5DA53DB36318
199 changed files with 742 additions and 710 deletions
Download patch file Download diff file Expand all files Collapse all files

6
launcher/modplatform/modrinth/ModrinthInstanceCreationTask.cpp
View file

@ -43,7 +43,7 @@ bool ModrinthCreationTask::updateInstance()
auto instance_list = APPLICATION->instances();
// FIXME: How to handle situations when there's more than one install already for a given modpack?
InstancePtr inst;
BaseInstance* inst;
if (auto original_id = originalInstanceID(); !original_id.isEmpty()) {
inst = instance_list->getInstanceById(original_id);
Q_ASSERT(inst);
@ -212,8 +212,8 @@ bool ModrinthCreationTask::createInstance()
}
QString configPath = FS::PathCombine(m_stagingPath, "instance.cfg");
auto instanceSettings = std::make_shared<INISettingsObject>(configPath);
MinecraftInstance instance(m_globalSettings, instanceSettings, m_stagingPath);
auto instanceSettings = std::make_unique<INISettingsObject>(configPath);
MinecraftInstance instance(m_globalSettings, std::move(instanceSettings), m_stagingPath);
auto components = instance.getPackProfile();
components->buildingFromScratch();