INIFile: add file name to error logging

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
This commit is contained in:
Octol1ttle 2026-05-05 18:41:06 +05:00
parent 4f58197edb
commit e7dbdf3489
No known key found for this signature in database
GPG key ID: B77C34313AEE1FFF

View file

@ -35,6 +35,8 @@
*/ */
#include "settings/INIFile.h" #include "settings/INIFile.h"
#include <AssertHelpers.h>
#include <FileSystem.h> #include <FileSystem.h>
#include <QDebug> #include <QDebug>
@ -62,11 +64,10 @@ bool INIFile::saveFile(QString fileName)
_settings_obj.sync(); _settings_obj.sync();
if (auto status = _settings_obj.status(); status != QSettings::Status::NoError) { if (auto status = _settings_obj.status(); status != QSettings::Status::NoError) {
// Shouldn't be possible!
Q_ASSERT(status != QSettings::Status::FormatError);
if (status == QSettings::Status::AccessError) if (status == QSettings::Status::AccessError)
qCritical() << "An access error occurred (e.g. trying to write to a read-only file)."; qCritical() << "An access error occurred while saving INI file" << fileName << "(is the file read-only?)";
if (ASSERT_NEVER(status == QSettings::Status::FormatError))
qCritical() << "A format error occurred while saving INI file" << fileName << "(this shouldn't be possible!)";
return false; return false;
} }
@ -178,9 +179,9 @@ bool INIFile::loadFile(QString fileName)
if (auto status = _settings_obj.status(); status != QSettings::Status::NoError) { if (auto status = _settings_obj.status(); status != QSettings::Status::NoError) {
if (status == QSettings::Status::AccessError) if (status == QSettings::Status::AccessError)
qCritical() << "An access error occurred (e.g. trying to write to a read-only file)."; qCritical() << "An access error occurred while loading INI file" << fileName;
if (status == QSettings::Status::FormatError) if (status == QSettings::Status::FormatError)
qCritical() << "A format error occurred (e.g. loading a malformed INI file)."; qCritical() << "A format error occurred while loading INI file" << fileName << "(is the file malformed or corrupted?)";
return false; return false;
} }
if (!_settings_obj.value("ConfigVersion").isValid()) { if (!_settings_obj.value("ConfigVersion").isValid()) {