mc-in-work/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2026-06-29 01:54:20 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix crash when updating datapacks

Browse source 
parent PR #5101
so for datapacks and datapacks only we need an extra check.
Why? Because Datapacks are treated as ModLoaderType but they aren't a
modloader. So the modLoaderTypesToList will generate an empty list even
if loader is 64 (not 0).

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
This commit is contained in:
Trial97 2026-03-10 08:55:33 +02:00
parent 437242169d
commit d958a91ce9
No known key found for this signature in database
GPG key ID: 55EF5DA53DB36318
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
launcher/modplatform/modrinth/ModrinthCheckUpdate.cpp
View file

@ -151,7 +151,10 @@ void ModrinthCheckUpdate::checkVersionsResponse(QByteArray* response, std::optio
// so we may want to filter it
QString loader_filter;
if (loader.has_value() && loader != 0) {
loader_filter = ModPlatform::getModLoaderAsString(ModPlatform::modLoaderTypesToList(*loader).first());
auto modLoaders = ModPlatform::modLoaderTypesToList(*loader);
if (!modLoaders.isEmpty()) {
loader_filter = ModPlatform::getModLoaderAsString(modLoaders.first());
}
}
// Currently, we rely on a couple heuristics to determine whether an update is actually available or not: