chore(clang-tidy): fix clang tidy warnings

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
This commit is contained in:
Trial97 2026-05-08 23:38:49 +03:00
parent 50216e7856
commit cbe143c266
No known key found for this signature in database
GPG key ID: 55EF5DA53DB36318
14 changed files with 115 additions and 110 deletions

View file

@ -68,8 +68,8 @@ bool shouldStopOnConsoleOverflow(SettingsObject* settings)
return settings->get("ConsoleOverflowStop").toBool();
}
BaseInstance::BaseInstance(SettingsObject* globalSettings, std::unique_ptr<SettingsObject> settings, const QString& rootDir)
: m_rootDir(rootDir), m_settings(std::move(settings)), m_global_settings(globalSettings)
BaseInstance::BaseInstance(SettingsObject* globalSettings, std::unique_ptr<SettingsObject> settings, QString rootDir)
: m_rootDir(std::move(rootDir)), m_settings(std::move(settings)), m_global_settings(globalSettings)
{
m_settings->registerSetting("name", "Unnamed Instance");
m_settings->registerSetting("iconKey", "default");
@ -423,7 +423,7 @@ QList<ShortcutData> BaseInstance::shortcuts() const
continue;
}
int value = dict["target"].toInt(-1);
if (!dict["name"].isString() || !dict["filePath"].isString() || value < 0 || value >= 3) {
if (!dict.value("name").isString() || !dict.value("filePath").isString() || value < 0 || value >= 3) {
continue;
}