mc-in-work/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2026-06-29 01:54:20 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor(instance creation): use RAII lock to suspend instance settings saving

Browse source 
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
This commit is contained in:
Octol1ttle 2026-01-08 04:04:29 +05:00
parent 3937819305
commit c24fd2f570
No known key found for this signature in database
GPG key ID: B77C34313AEE1FFF
4 changed files with 17 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

22
launcher/minecraft/VanillaInstanceCreationTask.cpp
View file

@ -19,21 +19,17 @@ bool VanillaCreationTask::createInstance()
{
setStatus(tr("Creating instance from version %1").arg(m_version->name()));
auto instance_settings = std::make_unique<INISettingsObject>(FS::PathCombine(m_stagingPath, "instance.cfg"));
instance_settings->suspendSave();
{
MinecraftInstance inst(m_globalSettings, std::move(instance_settings), m_stagingPath);
auto components = inst.getPackProfile();
components->buildingFromScratch();
components->setComponentVersion("net.minecraft", m_version->descriptor(), true);
if (m_using_loader)
components->setComponentVersion(m_loader, m_loader_version->descriptor());
MinecraftInstance inst(m_globalSettings, std::make_unique<INISettingsObject>(FS::PathCombine(m_stagingPath, "instance.cfg")), m_stagingPath);
SettingsObject::Lock lock(inst.settings());
inst.setName(name());
inst.setIconKey(m_instIcon);
auto components = inst.getPackProfile();
components->buildingFromScratch();
components->setComponentVersion("net.minecraft", m_version->descriptor(), true);
if (m_using_loader)
components->setComponentVersion(m_loader, m_loader_version->descriptor());
inst.settings()->resumeSave();
}
inst.setName(name());
inst.setIconKey(m_instIcon);
return true;
}