mc-in-work/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2026-06-29 01:54:20 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix(updater): do not reset current task in finished signal

Browse source 
The order of signals in case of a success is "succeeded"->"finished"

The "succeeded" signal may launch another download if the updater needs to fetch more pages
But if we reset the task then the newly started download will be disposed and the updater will softlock

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
(cherry picked from commit 9b270f783e)
This commit is contained in:
Octol1ttle 2026-04-12 13:02:46 +05:00 • committed by github-actions[bot]
parent a71b8d8fe3
commit add3d01f84
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
launcher/updater/prismupdater/PrismUpdater.cpp
View file

@ -1160,8 +1160,6 @@ void PrismUpdaterApp::downloadReleasePage(const QString& api_url, int page)
m_current_task.reset(download);
connect(download.get(), &Net::Download::finished, this, [this]() {
qDebug() << "Download" << m_current_task->getUid().toString() << "finished";
m_current_task.reset();
m_current_url = "";
});
QCoreApplication::processEvents();