mc-in-work/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2026-06-29 09:59:59 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Backport release-11.x] INIFile: add file name to error logging (#5509)

Browse source
This commit is contained in:
Alexandru Ionut Tripon 2026-05-07 14:56:43 +03:00 • committed by GitHub
commit 8eda25d46e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
launcher/settings/INIFile.cpp
View file

@ -35,6 +35,8 @@
*/
#include "settings/INIFile.h"
#include <AssertHelpers.h>
#include <FileSystem.h>
#include <QDebug>
@ -62,11 +64,10 @@ bool INIFile::saveFile(QString fileName)
_settings_obj.sync();
if (auto status = _settings_obj.status(); status != QSettings::Status::NoError) {
// Shouldn't be possible!
Q_ASSERT(status != QSettings::Status::FormatError);
if (status == QSettings::Status::AccessError)
qCritical() << "An access error occurred (e.g. trying to write to a read-only file).";
qCritical() << "An access error occurred while saving INI file" << fileName << "(is the file read-only?)";
if (ASSERT_NEVER(status == QSettings::Status::FormatError))
qCritical() << "A format error occurred while saving INI file" << fileName << "(this shouldn't be possible!)";
return false;
}
@ -178,9 +179,9 @@ bool INIFile::loadFile(QString fileName)
if (auto status = _settings_obj.status(); status != QSettings::Status::NoError) {
if (status == QSettings::Status::AccessError)
qCritical() << "An access error occurred (e.g. trying to write to a read-only file).";
qCritical() << "An access error occurred while loading INI file" << fileName;
if (status == QSettings::Status::FormatError)
qCritical() << "A format error occurred (e.g. loading a malformed INI file).";
qCritical() << "A format error occurred while loading INI file" << fileName << "(is the file malformed or corrupted?)";
return false;
}
if (!_settings_obj.value("ConfigVersion").isValid()) {