From 71c00170568295a96ea80980d55c2ddfa37bc805 Mon Sep 17 00:00:00 2001 From: Octol1ttle Date: Wed, 4 Mar 2026 22:16:48 +0500 Subject: [PATCH] fix: open correct wiki URL when opened from the `Help` *menu* Signed-off-by: Octol1ttle --- CMakeLists.txt | 3 ++- buildconfig/BuildConfig.cpp.in | 1 + buildconfig/BuildConfig.h | 7 ++++++- launcher/ui/MainWindow.cpp | 2 +- launcher/ui/MainWindow.ui | 2 +- 5 files changed, 11 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 05d28dec7..5f0377c15 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -172,7 +172,8 @@ endif() ######## Set URLs ######## set(Launcher_NEWS_RSS_URL "https://prismlauncher.org/feed/feed.xml" CACHE STRING "URL to fetch Prism Launcher's news RSS feed from.") set(Launcher_NEWS_OPEN_URL "https://prismlauncher.org/news" CACHE STRING "URL that gets opened when the user clicks 'More News'") -set(Launcher_HELP_URL "https://prismlauncher.org/wiki/help-pages/%1" CACHE STRING "URL (with arg %1 to be substituted with page-id) that gets opened when the user requests help") +set(Launcher_WIKI_URL "https://prismlauncher.org/wiki/" CACHE STRING "URL that gets opened when the user clicks 'Launcher Help'") +set(Launcher_HELP_URL "https://prismlauncher.org/wiki/help-pages/%1" CACHE STRING "URL (with arg %1 to be substituted with page-id) that gets opened when the user requests help in a dialog window") set(Launcher_LOGIN_CALLBACK_URL "https://prismlauncher.org/successful-login" CACHE STRING "URL that gets opened when the user successfully logins.") set(Launcher_LEGACY_FMLLIBS_BASE_URL "https://files.prismlauncher.org/fmllibs/" CACHE STRING "URL for legacy (<=1.5.2) FML Libraries.") diff --git a/buildconfig/BuildConfig.cpp.in b/buildconfig/BuildConfig.cpp.in index 3c5c74e9f..0d842a3ba 100644 --- a/buildconfig/BuildConfig.cpp.in +++ b/buildconfig/BuildConfig.cpp.in @@ -105,6 +105,7 @@ Config::Config() NEWS_RSS_URL = "@Launcher_NEWS_RSS_URL@"; NEWS_OPEN_URL = "@Launcher_NEWS_OPEN_URL@"; + WIKI_URL = "@Launcher_WIKI_URL@"; HELP_URL = "@Launcher_HELP_URL@"; LOGIN_CALLBACK_URL = "@Launcher_LOGIN_CALLBACK_URL@"; IMGUR_CLIENT_ID = "@Launcher_IMGUR_CLIENT_ID@"; diff --git a/buildconfig/BuildConfig.h b/buildconfig/BuildConfig.h index 1a03c7761..7bd7f4ff4 100644 --- a/buildconfig/BuildConfig.h +++ b/buildconfig/BuildConfig.h @@ -128,7 +128,12 @@ class Config { QString NEWS_OPEN_URL; /** - * URL (with arg %1 to be substituted with page-id) that gets opened when the user requests help + * URL that gets opened when the user clicks 'Launcher Help' + */ + QString WIKI_URL; + + /** + * URL (with arg %1 to be substituted with page-id) that gets opened when the user requests help in a dialog window */ QString HELP_URL; diff --git a/launcher/ui/MainWindow.cpp b/launcher/ui/MainWindow.cpp index bd6cfb50e..1a6c37a5a 100644 --- a/launcher/ui/MainWindow.cpp +++ b/launcher/ui/MainWindow.cpp @@ -1357,7 +1357,7 @@ void MainWindow::on_actionAddToPATH_triggered() void MainWindow::on_actionOpenWiki_triggered() { - DesktopServices::openUrl(QUrl(BuildConfig.HELP_URL.arg(""))); + DesktopServices::openUrl(QUrl(BuildConfig.WIKI_URL)); } void MainWindow::on_actionMoreNews_triggered() diff --git a/launcher/ui/MainWindow.ui b/launcher/ui/MainWindow.ui index ff1b4a25a..353788518 100644 --- a/launcher/ui/MainWindow.ui +++ b/launcher/ui/MainWindow.ui @@ -721,7 +721,7 @@ - %1 &Help + %1 &Wiki Open the %1 wiki