mc-in-work/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2026-07-03 11:56:57 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(instance creation): use RAII lock to suspend instance settings saving

Browse source 
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
(cherry picked from commit c24fd2f570)
This commit is contained in:
Octol1ttle 2026-01-08 04:04:29 +05:00 • committed by Trial97
parent 1b88f31ec8
commit 782cda92a9
No known key found for this signature in database
GPG key ID: 55EF5DA53DB36318
4 changed files with 17 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

8
launcher/modplatform/import_ftb/PackInstallTask.cpp
View file

@ -49,10 +49,11 @@ void PackInstallTask::copySettings()
{
setStatus(tr("Copying settings..."));
progress(2, 2);
QString instanceConfigPath = FS::PathCombine(m_stagingPath, "instance.cfg");
auto instanceSettings = std::make_unique<INISettingsObject>(instanceConfigPath);
instanceSettings->suspendSave();
MinecraftInstance instance(m_globalSettings, std::move(instanceSettings), m_stagingPath);
MinecraftInstance instance(m_globalSettings, std::make_unique<INISettingsObject>(instanceConfigPath), m_stagingPath);
SettingsObject::Lock lock(instance.settings());
instance.settings()->set("InstanceType", "OneSix");
instance.settings()->set("totalTimePlayed", m_pack.totalPlayTime / 1000);
@ -107,7 +108,6 @@ void PackInstallTask::copySettings()
if (m_instIcon == "default")
m_instIcon = "ftb_logo";
instance.setIconKey(m_instIcon);
instance.settings()->resumeSave();
emitSucceeded();
}