Fix memory leak and crash with data packs modal (#5551)
Some checks are pending
Nix / Build (aarch64-darwin) (push) Waiting to run
Nix / Build (x86_64-linux) (push) Waiting to run
Nix / Build (aarch64-linux) (push) Waiting to run

This commit is contained in:
Alexandru Ionut Tripon 2026-06-04 05:38:22 +00:00 committed by GitHub
commit 6f3574f328
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -121,7 +121,7 @@ void WorldListPage::openedImpl()
ui->toolBar->removeAction(ui->actionJoin); ui->toolBar->removeAction(ui->actionJoin);
} }
auto const setting_name = QString("WideBarVisibility_%1").arg(id()); const auto setting_name = QString("WideBarVisibility_%1").arg(id());
m_wide_bar_setting = APPLICATION->settings()->getOrRegisterSetting(setting_name); m_wide_bar_setting = APPLICATION->settings()->getOrRegisterSetting(setting_name);
ui->toolBar->setVisibilityState(QByteArray::fromBase64(m_wide_bar_setting->get().toString().toUtf8())); ui->toolBar->setVisibilityState(QByteArray::fromBase64(m_wide_bar_setting->get().toString().toUtf8()));
@ -259,9 +259,12 @@ void WorldListPage::on_actionData_Packs_triggered()
dialog->setLayout(layout); dialog->setLayout(layout);
dialog->exec(); dialog->setAttribute(Qt::WA_DeleteOnClose);
APPLICATION->settings()->set("DataPackDownloadGeometry", dialog->saveGeometry().toBase64()); connect(dialog, &QDialog::finished, this,
[dialog]() { APPLICATION->settings()->set("DataPackDownloadGeometry", dialog->saveGeometry().toBase64()); });
dialog->open();
} }
void WorldListPage::on_actionReset_Icon_triggered() void WorldListPage::on_actionReset_Icon_triggered()