From 11df688cb494e0b7b434afefe0cd1a70deee54ae Mon Sep 17 00:00:00 2001 From: Octol1ttle Date: Sun, 12 Apr 2026 13:48:15 +0500 Subject: [PATCH] change(Task): warn when disposing while running Signed-off-by: Octol1ttle (cherry picked from commit ae7e1435373aa07ec5dbcbb9f22973e1f3cd93b7) --- launcher/tasks/Task.cpp | 7 +++++++ launcher/tasks/Task.h | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/launcher/tasks/Task.cpp b/launcher/tasks/Task.cpp index a54b4e7c2..5857a0663 100644 --- a/launcher/tasks/Task.cpp +++ b/launcher/tasks/Task.cpp @@ -48,6 +48,13 @@ Task::Task(bool show_debug) : m_show_debug(show_debug) setAutoDelete(false); } +Task::~Task() +{ + if (isRunning()) { + qCWarning(taskLogC) << "Task" << describe() << "disposed while running!"; + } +} + void Task::setStatus(const QString& new_status) { if (m_status != new_status) { diff --git a/launcher/tasks/Task.h b/launcher/tasks/Task.h index 94fb57783..6591ca302 100644 --- a/launcher/tasks/Task.h +++ b/launcher/tasks/Task.h @@ -94,7 +94,7 @@ class Task : public QObject, public QRunnable { public: explicit Task(bool show_debug_log = true); - virtual ~Task() = default; + ~Task() override; bool isRunning() const; bool isFinished() const;