mc-in-work/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2026-06-29 01:54:20 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

cleanup: code review sugestions

Browse source 
clean up translation strings

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
This commit is contained in:
Rachel Powers 2023-03-03 06:33:37 -07:00
parent dc5402349e
commit 458c2f38bc
9 changed files with 30 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

24
launcher/BaseInstance.cpp
View file

@ -66,7 +66,7 @@ BaseInstance::BaseInstance(SettingsObjectPtr globalSettings, SettingsObjectPtr s
m_settings->registerSetting("totalTimePlayed", 0);
m_settings->registerSetting("lastTimePlayed", 0);
m_settings->registerSetting("linkedInstancesList", "[]");
m_settings->registerSetting("linkedInstances", "[]");
// Game time override
auto gameTimeOverride = m_settings->registerSetting("OverrideGameTime", false);
@ -188,34 +188,34 @@ bool BaseInstance::shouldStopOnConsoleOverflow() const
QStringList BaseInstance::getLinkedInstances() const
{
return m_settings->getList<QString>("linkedInstancesList");
return m_settings->getList<QString>("linkedInstances");
}
void BaseInstance::setLinkedInstances(const QStringList& list)
{
auto linkedInstancesList = m_settings->getList<QString>("linkedInstancesList");
m_settings->setList("linkedInstancesList", list);
auto linkedInstances = m_settings->getList<QString>("linkedInstances");
m_settings->setList("linkedInstances", list);
}
void BaseInstance::addLinkedInstanceId(const QString& id)
{
auto linkedInstancesList = m_settings->getList<QString>("linkedInstancesList");
linkedInstancesList.append(id);
setLinkedInstances(linkedInstancesList);
auto linkedInstances = m_settings->getList<QString>("linkedInstances");
linkedInstances.append(id);
setLinkedInstances(linkedInstances);
}
bool BaseInstance::removeLinkedInstanceId(const QString& id)
{
auto linkedInstancesList = m_settings->getList<QString>("linkedInstancesList");
int numRemoved = linkedInstancesList.removeAll(id);
setLinkedInstances(linkedInstancesList);
auto linkedInstances = m_settings->getList<QString>("linkedInstances");
int numRemoved = linkedInstances.removeAll(id);
setLinkedInstances(linkedInstances);
return numRemoved > 0;
}
bool BaseInstance::isLinkedToInstanceId(const QString& id) const
{
auto linkedInstancesList = m_settings->getList<QString>("linkedInstancesList");
return linkedInstancesList.contains(id);
auto linkedInstances = m_settings->getList<QString>("linkedInstances");
return linkedInstances.contains(id);
}
void BaseInstance::iconUpdated(QString key)