From 170d59de2a60bd3a2ec06e56f4fbe08b665a588a Mon Sep 17 00:00:00 2001 From: Trial97 Date: Wed, 7 Jan 2026 03:04:19 +0200 Subject: [PATCH] deprecate any qt version older than qt 6.9.3 Signed-off-by: Trial97 --- .github/workflows/codeql.yml | 2 +- CMakeLists.txt | 4 +- launcher/MTPixmapCache.h | 9 ++++- launcher/VersionProxyModel.cpp | 10 ++++- launcher/meta/Version.cpp | 2 +- .../auth/steps/MSADeviceCodeStep.cpp | 5 --- launcher/minecraft/skins/SkinModel.cpp | 2 +- .../modplatform/legacy_ftb/PackFetchTask.cpp | 9 ++--- launcher/news/NewsChecker.cpp | 14 +++---- launcher/ui/dialogs/ExportToModListDialog.cpp | 8 ++-- launcher/ui/dialogs/ExportToModListDialog.h | 2 +- .../ui/dialogs/skins/SkinManageDialog.cpp | 4 +- launcher/ui/dialogs/skins/draw/Scene.cpp | 8 ++-- launcher/ui/java/InstallJavaDialog.cpp | 2 +- launcher/ui/pages/modplatform/CustomPage.cpp | 10 ++--- launcher/ui/widgets/JavaSettingsWidget.cpp | 5 +-- launcher/ui/widgets/JavaWizardWidget.cpp | 4 +- .../ui/widgets/LanguageSelectionWidget.cpp | 4 +- .../ui/widgets/MinecraftSettingsWidget.cpp | 2 +- launcher/ui/widgets/ModFilterWidget.cpp | 38 +++++++++---------- 20 files changed, 76 insertions(+), 68 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index f9705bf53..436ae07ee 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -37,7 +37,7 @@ jobs: uses: ./.github/actions/setup-dependencies with: build-type: Debug - qt-version: 6.4.3 + qt-version: 6.9.3 - name: Configure and Build run: | diff --git a/CMakeLists.txt b/CMakeLists.txt index 12afdefcc..23faf920f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -36,8 +36,8 @@ set(CMAKE_C_STANDARD 11) include(GenerateExportHeader) add_compile_definitions($<$>:QT_NO_DEBUG>) -add_compile_definitions(QT_WARN_DEPRECATED_UP_TO=0x060400) -add_compile_definitions(QT_DISABLE_DEPRECATED_UP_TO=0x060400) +add_compile_definitions(QT_WARN_DEPRECATED_UP_TO=0x060D00) +add_compile_definitions(QT_DISABLE_DEPRECATED_UP_TO=0x060903) if(CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC") add_compile_options( diff --git a/launcher/MTPixmapCache.h b/launcher/MTPixmapCache.h index 0ba9c5ac8..e7f6dfbe3 100644 --- a/launcher/MTPixmapCache.h +++ b/launcher/MTPixmapCache.h @@ -88,7 +88,14 @@ class PixmapCache final : public QObject { QPixmapCache::remove(key); return true; } - bool _replace(const QPixmapCache::Key& key, const QPixmap& pixmap) { return QPixmapCache::replace(key, pixmap); } + bool _replace(const QPixmapCache::Key& key, const QPixmap& pixmap) + { + if (!key.isValid()) + return false; + remove(key); + const_cast(key) = insert(pixmap); + return key.isValid(); + } bool _setCacheLimit(int n) { QPixmapCache::setCacheLimit(n); diff --git a/launcher/VersionProxyModel.cpp b/launcher/VersionProxyModel.cpp index aaab7e8e0..f38c56f95 100644 --- a/launcher/VersionProxyModel.cpp +++ b/launcher/VersionProxyModel.cpp @@ -70,7 +70,15 @@ class VersionFilterModel : public QSortFilterProxyModel { return true; } - void filterChanged() { invalidateFilter(); } + void filterChanged() + { +#if QT_VERSION < QT_VERSION_CHECK(6, 10, 0) + invalidateFilter(); +#else + beginFilterChange(); + endFilterChange(); +#endif + } private: VersionProxyModel* m_parent; diff --git a/launcher/meta/Version.cpp b/launcher/meta/Version.cpp index ce9a9cc8a..156dfc65a 100644 --- a/launcher/meta/Version.cpp +++ b/launcher/meta/Version.cpp @@ -38,7 +38,7 @@ QString Meta::Version::typeString() const QDateTime Meta::Version::time() const { - return QDateTime::fromMSecsSinceEpoch(m_time * 1000, Qt::UTC); + return QDateTime::fromMSecsSinceEpoch(m_time * 1000, QTimeZone::UTC); } void Meta::Version::parse(const QJsonObject& obj) diff --git a/launcher/minecraft/auth/steps/MSADeviceCodeStep.cpp b/launcher/minecraft/auth/steps/MSADeviceCodeStep.cpp index 13c26c1a0..f2cdf8ed6 100644 --- a/launcher/minecraft/auth/steps/MSADeviceCodeStep.cpp +++ b/launcher/minecraft/auth/steps/MSADeviceCodeStep.cpp @@ -83,11 +83,6 @@ MSADeviceCodeStep::MSADeviceCodeStep(AccountData* data) : AuthStep(data) connect(&m_oauth2, &QOAuth2DeviceAuthorizationFlow::clientIdentifierChanged, this, [this](const QString& clientIdentifier) { m_data->msaClientID = clientIdentifier; }); - connect(&m_oauth2, &QOAuth2DeviceAuthorizationFlow::userCodeExpirationAtChanged, this, [](const QDateTime& expiration) { - qDebug() << "============="; - qDebug() << expiration; - qDebug() << "============="; - }); } QString MSADeviceCodeStep::describe() diff --git a/launcher/minecraft/skins/SkinModel.cpp b/launcher/minecraft/skins/SkinModel.cpp index e2c41f17b..8904b15a0 100644 --- a/launcher/minecraft/skins/SkinModel.cpp +++ b/launcher/minecraft/skins/SkinModel.cpp @@ -71,7 +71,7 @@ static QImage improveSkin(QImage skin) auto copyRect = [&p, &newSkin](int startX, int startY, int offsetX, int offsetY, int sizeX, int sizeY) { QImage region = newSkin.copy(startX, startY, sizeX, sizeY); - region = region.mirrored(true, false); + region = region.flipped(Qt::Horizontal); p.drawImage(startX + offsetX, startY + offsetY, region); }; diff --git a/launcher/modplatform/legacy_ftb/PackFetchTask.cpp b/launcher/modplatform/legacy_ftb/PackFetchTask.cpp index 7d1807ab3..cc8246835 100644 --- a/launcher/modplatform/legacy_ftb/PackFetchTask.cpp +++ b/launcher/modplatform/legacy_ftb/PackFetchTask.cpp @@ -134,12 +134,11 @@ bool PackFetchTask::parseAndAddPacks(QByteArray& data, PackType packType, Modpac { QDomDocument doc; - QString errorMsg = "Unknown error."; - int errorLine = -1; - int errorCol = -1; + auto result = doc.setContent(data); - if (!doc.setContent(data, false, &errorMsg, &errorLine, &errorCol)) { - auto fullErrMsg = QString("Failed to fetch modpack data: %1 %2:%3!").arg(errorMsg).arg(errorLine).arg(errorCol); + if (!result) { + auto fullErrMsg = + QString("Failed to fetch modpack data: %1 %2:%3!").arg(result.errorMessage).arg(result.errorLine).arg(result.errorColumn); qWarning() << fullErrMsg; return false; } diff --git a/launcher/news/NewsChecker.cpp b/launcher/news/NewsChecker.cpp index 35173dd7b..c6dbb4e07 100644 --- a/launcher/news/NewsChecker.cpp +++ b/launcher/news/NewsChecker.cpp @@ -76,18 +76,18 @@ void NewsChecker::rssDownloadFinished() m_newsNetJob.reset(); QDomDocument doc; { - // Stuff to store error info in. - QString errorMsg = "Unknown error."; - int errorLine = -1; - int errorCol = -1; - QFile feed(m_entry->getFullPath()); if (feed.open(QFile::ReadOnly | QFile::Text)) { QTextStream in(&feed); // Parse the XML. - if (!doc.setContent(in.readAll(), false, &errorMsg, &errorLine, &errorCol)) { - fail(QString("Error parsing RSS feed XML. %1 at %2:%3.").arg(errorMsg).arg(errorLine).arg(errorCol)); + auto result = doc.setContent(in.readAll()); + if (!result) { + QString fullErrorMsg = QString("Error parsing RSS feed XML. %1 at %2:%3.") + .arg(result.errorMessage) + .arg(result.errorLine) + .arg(result.errorColumn); + fail(fullErrorMsg); return; } } diff --git a/launcher/ui/dialogs/ExportToModListDialog.cpp b/launcher/ui/dialogs/ExportToModListDialog.cpp index e8873f9b4..95d44f1c0 100644 --- a/launcher/ui/dialogs/ExportToModListDialog.cpp +++ b/launcher/ui/dialogs/ExportToModListDialog.cpp @@ -47,10 +47,10 @@ ExportToModListDialog::ExportToModListDialog(QString name, QList mods, QWi enableCustom(false); connect(ui->formatComboBox, &QComboBox::currentIndexChanged, this, &ExportToModListDialog::formatChanged); - connect(ui->authorsCheckBox, &QCheckBox::stateChanged, this, &ExportToModListDialog::trigger); - connect(ui->versionCheckBox, &QCheckBox::stateChanged, this, &ExportToModListDialog::trigger); - connect(ui->urlCheckBox, &QCheckBox::stateChanged, this, &ExportToModListDialog::trigger); - connect(ui->filenameCheckBox, &QCheckBox::stateChanged, this, &ExportToModListDialog::trigger); + connect(ui->authorsCheckBox, &QCheckBox::checkStateChanged, this, &ExportToModListDialog::trigger); + connect(ui->versionCheckBox, &QCheckBox::checkStateChanged, this, &ExportToModListDialog::trigger); + connect(ui->urlCheckBox, &QCheckBox::checkStateChanged, this, &ExportToModListDialog::trigger); + connect(ui->filenameCheckBox, &QCheckBox::checkStateChanged, this, &ExportToModListDialog::trigger); connect(ui->authorsButton, &QPushButton::clicked, this, [this](bool) { addExtra(ExportToModList::Authors); }); connect(ui->versionButton, &QPushButton::clicked, this, [this](bool) { addExtra(ExportToModList::Version); }); connect(ui->urlButton, &QPushButton::clicked, this, [this](bool) { addExtra(ExportToModList::Url); }); diff --git a/launcher/ui/dialogs/ExportToModListDialog.h b/launcher/ui/dialogs/ExportToModListDialog.h index 4ebe203f7..2120e3308 100644 --- a/launcher/ui/dialogs/ExportToModListDialog.h +++ b/launcher/ui/dialogs/ExportToModListDialog.h @@ -39,7 +39,7 @@ class ExportToModListDialog : public QDialog { protected slots: void formatChanged(int index); void triggerImp(); - void trigger(int) { triggerImp(); }; + void trigger(Qt::CheckState) { triggerImp(); }; void addExtra(ExportToModList::OptionalData option); private: diff --git a/launcher/ui/dialogs/skins/SkinManageDialog.cpp b/launcher/ui/dialogs/skins/SkinManageDialog.cpp index 4dfeeaa34..a3f288c3a 100644 --- a/launcher/ui/dialogs/skins/SkinManageDialog.cpp +++ b/launcher/ui/dialogs/skins/SkinManageDialog.cpp @@ -98,7 +98,7 @@ SkinManageDialog::SkinManageDialog(QWidget* parent, MinecraftAccountPtr acct) connect(contentsWidget->selectionModel(), &QItemSelectionModel::selectionChanged, this, &SkinManageDialog::selectionChanged); connect(m_ui->listView, &QListView::customContextMenuRequested, this, &SkinManageDialog::show_context_menu); - connect(m_ui->elytraCB, &QCheckBox::stateChanged, this, [this]() { + connect(m_ui->elytraCB, &QCheckBox::checkStateChanged, this, [this]() { if (m_skinPreview) { m_skinPreview->setElytraVisible(m_ui->elytraCB->isChecked()); } @@ -186,7 +186,7 @@ QPixmap previewCape(QImage capeImage, bool elytra = false) { if (elytra) { auto wing = capeImage.copy(34, 2, 12, 20); - QImage mirrored = wing.mirrored(true, false); + QImage mirrored = wing.flipped(Qt::Horizontal); QImage combined(wing.width() * 2 + 1, wing.height() + 14, capeImage.format()); combined.fill(Qt::transparent); diff --git a/launcher/ui/dialogs/skins/draw/Scene.cpp b/launcher/ui/dialogs/skins/draw/Scene.cpp index 1d06c694f..47c390ac1 100644 --- a/launcher/ui/dialogs/skins/draw/Scene.cpp +++ b/launcher/ui/dialogs/skins/draw/Scene.cpp @@ -96,11 +96,11 @@ Scene::Scene(const QImage& skin, bool slim, const QImage& cape) : QOpenGLFunctio m_elytra << leftWing << rightWing; // texture init - m_skinTexture = new QOpenGLTexture(skin.mirrored()); + m_skinTexture = new QOpenGLTexture(skin.flipped()); m_skinTexture->setMinificationFilter(QOpenGLTexture::Nearest); m_skinTexture->setMagnificationFilter(QOpenGLTexture::Nearest); - m_capeTexture = new QOpenGLTexture(cape.mirrored()); + m_capeTexture = new QOpenGLTexture(cape.flipped()); m_capeTexture->setMinificationFilter(QOpenGLTexture::Nearest); m_capeTexture->setMagnificationFilter(QOpenGLTexture::Nearest); } @@ -162,7 +162,7 @@ void updateTexture(QOpenGLTexture* texture, const QImage& img) void Scene::setSkin(const QImage& skin) { - updateTexture(m_skinTexture, skin.mirrored()); + updateTexture(m_skinTexture, skin.flipped()); } void Scene::setMode(bool slim) @@ -171,7 +171,7 @@ void Scene::setMode(bool slim) } void Scene::setCape(const QImage& cape) { - updateTexture(m_capeTexture, cape.mirrored()); + updateTexture(m_capeTexture, cape.flipped()); } void Scene::setCapeVisible(bool visible) { diff --git a/launcher/ui/java/InstallJavaDialog.cpp b/launcher/ui/java/InstallJavaDialog.cpp index fd8e43398..dddfb8789 100644 --- a/launcher/ui/java/InstallJavaDialog.cpp +++ b/launcher/ui/java/InstallJavaDialog.cpp @@ -207,7 +207,7 @@ InstallDialog::InstallDialog(const QString& uid, BaseInstance* instance, QWidget auto recommendedCheckBox = new QCheckBox("Recommended", this); recommendedCheckBox->setCheckState(Qt::CheckState::Checked); - connect(recommendedCheckBox, &QCheckBox::stateChanged, this, [this](int state) { + connect(recommendedCheckBox, &QCheckBox::checkStateChanged, this, [this](Qt::CheckState state) { for (BasePage* page : container->getPages()) { pageCast(page)->setRecommend(state == Qt::Checked); } diff --git a/launcher/ui/pages/modplatform/CustomPage.cpp b/launcher/ui/pages/modplatform/CustomPage.cpp index f24abf9fb..3ebc09406 100644 --- a/launcher/ui/pages/modplatform/CustomPage.cpp +++ b/launcher/ui/pages/modplatform/CustomPage.cpp @@ -51,11 +51,11 @@ CustomPage::CustomPage(NewInstanceDialog* dialog, QWidget* parent) : QWidget(par ui->setupUi(this); connect(ui->versionList, &VersionSelectWidget::selectedVersionChanged, this, &CustomPage::setSelectedVersion); filterChanged(); - connect(ui->alphaFilter, &QCheckBox::stateChanged, this, &CustomPage::filterChanged); - connect(ui->betaFilter, &QCheckBox::stateChanged, this, &CustomPage::filterChanged); - connect(ui->snapshotFilter, &QCheckBox::stateChanged, this, &CustomPage::filterChanged); - connect(ui->releaseFilter, &QCheckBox::stateChanged, this, &CustomPage::filterChanged); - connect(ui->experimentsFilter, &QCheckBox::stateChanged, this, &CustomPage::filterChanged); + connect(ui->alphaFilter, &QCheckBox::checkStateChanged, this, &CustomPage::filterChanged); + connect(ui->betaFilter, &QCheckBox::checkStateChanged, this, &CustomPage::filterChanged); + connect(ui->snapshotFilter, &QCheckBox::checkStateChanged, this, &CustomPage::filterChanged); + connect(ui->releaseFilter, &QCheckBox::checkStateChanged, this, &CustomPage::filterChanged); + connect(ui->experimentsFilter, &QCheckBox::checkStateChanged, this, &CustomPage::filterChanged); connect(ui->refreshBtn, &QPushButton::clicked, this, &CustomPage::refresh); connect(ui->loaderVersionList, &VersionSelectWidget::selectedVersionChanged, this, &CustomPage::setSelectedLoaderVersion); diff --git a/launcher/ui/widgets/JavaSettingsWidget.cpp b/launcher/ui/widgets/JavaSettingsWidget.cpp index e13c847d0..9c96fd432 100644 --- a/launcher/ui/widgets/JavaSettingsWidget.cpp +++ b/launcher/ui/widgets/JavaSettingsWidget.cpp @@ -62,9 +62,9 @@ JavaSettingsWidget::JavaSettingsWidget(BaseInstance* instance, QWidget* parent) if (m_instance == nullptr) { m_ui->javaDownloadBtn->hide(); if (BuildConfig.JAVA_DOWNLOADER_ENABLED) { - connect(m_ui->autodetectJavaCheckBox, &QCheckBox::stateChanged, this, [this](bool state) { + connect(m_ui->autodetectJavaCheckBox, &QCheckBox::checkStateChanged, this, [this](Qt::CheckState state) { m_ui->autodownloadJavaCheckBox->setEnabled(state); - if (!state) + if (state != Qt::Checked) m_ui->autodownloadJavaCheckBox->setChecked(false); }); } else { @@ -135,7 +135,6 @@ void JavaSettingsWidget::loadSettings() if (m_instance == nullptr) { m_ui->skipWizardCheckBox->setChecked(settings->get("IgnoreJavaWizard").toBool()); m_ui->autodetectJavaCheckBox->setChecked(settings->get("AutomaticJavaSwitch").toBool()); - m_ui->autodetectJavaCheckBox->stateChanged(m_ui->autodetectJavaCheckBox->isChecked()); m_ui->autodownloadJavaCheckBox->setChecked(settings->get("AutomaticJavaDownload").toBool()); } diff --git a/launcher/ui/widgets/JavaWizardWidget.cpp b/launcher/ui/widgets/JavaWizardWidget.cpp index bcf498b6d..8b97c2239 100644 --- a/launcher/ui/widgets/JavaWizardWidget.cpp +++ b/launcher/ui/widgets/JavaWizardWidget.cpp @@ -152,13 +152,13 @@ void JavaWizardWidget::setupUi() m_autodownloadCheckBox->setObjectName("autodownloadCheckBox"); m_autodownloadCheckBox->setEnabled(m_autodetectJavaCheckBox->isChecked()); m_veriticalJavaLayout->addWidget(m_autodownloadCheckBox); - connect(m_autodetectJavaCheckBox, &QCheckBox::stateChanged, this, [this] { + connect(m_autodetectJavaCheckBox, &QCheckBox::checkStateChanged, this, [this] { m_autodownloadCheckBox->setEnabled(m_autodetectJavaCheckBox->isChecked()); if (!m_autodetectJavaCheckBox->isChecked()) m_autodownloadCheckBox->setChecked(false); }); - connect(m_autodownloadCheckBox, &QCheckBox::stateChanged, this, [this] { + connect(m_autodownloadCheckBox, &QCheckBox::checkStateChanged, this, [this] { auto isChecked = m_autodownloadCheckBox->isChecked(); m_versionWidget->setVisible(!isChecked); m_javaStatusBtn->setVisible(!isChecked); diff --git a/launcher/ui/widgets/LanguageSelectionWidget.cpp b/launcher/ui/widgets/LanguageSelectionWidget.cpp index 3f35df7b0..bd6d82226 100644 --- a/launcher/ui/widgets/LanguageSelectionWidget.cpp +++ b/launcher/ui/widgets/LanguageSelectionWidget.cpp @@ -35,8 +35,8 @@ LanguageSelectionWidget::LanguageSelectionWidget(QWidget* parent) : QWidget(pare formatCheckbox = new QCheckBox(this); formatCheckbox->setObjectName(QStringLiteral("formatCheckbox")); formatCheckbox->setCheckState(APPLICATION->settings()->get("UseSystemLocale").toBool() ? Qt::Checked : Qt::Unchecked); - connect(formatCheckbox, &QCheckBox::stateChanged, - [this]() { APPLICATION->translations()->setUseSystemLocale(formatCheckbox->isChecked()); }); + connect(formatCheckbox, &QCheckBox::checkStateChanged, + [this] { APPLICATION->translations()->setUseSystemLocale(formatCheckbox->isChecked()); }); verticalLayout->addWidget(formatCheckbox); auto translations = APPLICATION->translations(); diff --git a/launcher/ui/widgets/MinecraftSettingsWidget.cpp b/launcher/ui/widgets/MinecraftSettingsWidget.cpp index 460068bd3..b68f37d9a 100644 --- a/launcher/ui/widgets/MinecraftSettingsWidget.cpp +++ b/launcher/ui/widgets/MinecraftSettingsWidget.cpp @@ -118,7 +118,7 @@ MinecraftSettingsWidget::MinecraftSettingsWidget(MinecraftInstance* instance, QW for (auto c : { m_ui->neoForge, m_ui->forge, m_ui->fabric, m_ui->quilt, m_ui->liteLoader, m_ui->babric, m_ui->btaBabric, m_ui->legacyFabric, m_ui->ornithe, m_ui->rift }) { - connect(c, &QCheckBox::stateChanged, this, &MinecraftSettingsWidget::saveSelectedLoaders); + connect(c, &QCheckBox::checkStateChanged, this, &MinecraftSettingsWidget::saveSelectedLoaders); } } diff --git a/launcher/ui/widgets/ModFilterWidget.cpp b/launcher/ui/widgets/ModFilterWidget.cpp index 6fab2b2a5..437cf3a4b 100644 --- a/launcher/ui/widgets/ModFilterWidget.cpp +++ b/launcher/ui/widgets/ModFilterWidget.cpp @@ -140,21 +140,21 @@ ModFilterWidget::ModFilterWidget(MinecraftInstance* instance, bool extended) ui->versions->setStyleSheet("combobox-popup: 0;"); ui->version->setStyleSheet("combobox-popup: 0;"); - connect(ui->showAllVersions, &QCheckBox::stateChanged, this, &ModFilterWidget::onShowAllVersionsChanged); + connect(ui->showAllVersions, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onShowAllVersionsChanged); connect(ui->versions, &QComboBox::currentIndexChanged, this, &ModFilterWidget::onVersionFilterChanged); connect(ui->versions, &CheckComboBox::checkedItemsChanged, this, [this] { onVersionFilterChanged(0); }); connect(ui->version, &QComboBox::currentTextChanged, this, &ModFilterWidget::onVersionFilterTextChanged); - connect(ui->neoForge, &QCheckBox::stateChanged, this, &ModFilterWidget::onLoadersFilterChanged); - connect(ui->forge, &QCheckBox::stateChanged, this, &ModFilterWidget::onLoadersFilterChanged); - connect(ui->fabric, &QCheckBox::stateChanged, this, &ModFilterWidget::onLoadersFilterChanged); - connect(ui->quilt, &QCheckBox::stateChanged, this, &ModFilterWidget::onLoadersFilterChanged); - connect(ui->liteLoader, &QCheckBox::stateChanged, this, &ModFilterWidget::onLoadersFilterChanged); - connect(ui->babric, &QCheckBox::stateChanged, this, &ModFilterWidget::onLoadersFilterChanged); - connect(ui->btaBabric, &QCheckBox::stateChanged, this, &ModFilterWidget::onLoadersFilterChanged); - connect(ui->legacyFabric, &QCheckBox::stateChanged, this, &ModFilterWidget::onLoadersFilterChanged); - connect(ui->ornithe, &QCheckBox::stateChanged, this, &ModFilterWidget::onLoadersFilterChanged); - connect(ui->rift, &QCheckBox::stateChanged, this, &ModFilterWidget::onLoadersFilterChanged); + connect(ui->neoForge, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onLoadersFilterChanged); + connect(ui->forge, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onLoadersFilterChanged); + connect(ui->fabric, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onLoadersFilterChanged); + connect(ui->quilt, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onLoadersFilterChanged); + connect(ui->liteLoader, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onLoadersFilterChanged); + connect(ui->babric, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onLoadersFilterChanged); + connect(ui->btaBabric, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onLoadersFilterChanged); + connect(ui->legacyFabric, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onLoadersFilterChanged); + connect(ui->ornithe, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onLoadersFilterChanged); + connect(ui->rift, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onLoadersFilterChanged); connect(ui->showMoreButton, &QPushButton::clicked, this, &ModFilterWidget::onShowMoreClicked); @@ -164,17 +164,17 @@ ModFilterWidget::ModFilterWidget(MinecraftInstance* instance, bool extended) } if (extended) { - connect(ui->clientSide, &QCheckBox::stateChanged, this, &ModFilterWidget::onSideFilterChanged); - connect(ui->serverSide, &QCheckBox::stateChanged, this, &ModFilterWidget::onSideFilterChanged); + connect(ui->clientSide, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onSideFilterChanged); + connect(ui->serverSide, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onSideFilterChanged); } - connect(ui->hideInstalled, &QCheckBox::stateChanged, this, &ModFilterWidget::onHideInstalledFilterChanged); - connect(ui->openSource, &QCheckBox::stateChanged, this, &ModFilterWidget::onOpenSourceFilterChanged); + connect(ui->hideInstalled, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onHideInstalledFilterChanged); + connect(ui->openSource, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onOpenSourceFilterChanged); - connect(ui->releaseCb, &QCheckBox::stateChanged, this, &ModFilterWidget::onReleaseFilterChanged); - connect(ui->betaCb, &QCheckBox::stateChanged, this, &ModFilterWidget::onReleaseFilterChanged); - connect(ui->alphaCb, &QCheckBox::stateChanged, this, &ModFilterWidget::onReleaseFilterChanged); - connect(ui->unknownCb, &QCheckBox::stateChanged, this, &ModFilterWidget::onReleaseFilterChanged); + connect(ui->releaseCb, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onReleaseFilterChanged); + connect(ui->betaCb, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onReleaseFilterChanged); + connect(ui->alphaCb, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onReleaseFilterChanged); + connect(ui->unknownCb, &QCheckBox::checkStateChanged, this, &ModFilterWidget::onReleaseFilterChanged); setHidden(true); loadVersionList();