From 0f9be64d6c575ce698bfddd2c45d4578bdf8d457 Mon Sep 17 00:00:00 2001
From: Octol1ttle <l1ttleofficial@outlook.com>
Date: Sun, 3 May 2026 18:14:09 +0500
Subject: [PATCH] fix(PrismExternalUpdater): do not show "No updates available"
 when ignoring skipped version during autocheck

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
---
 launcher/updater/PrismExternalUpdater.cpp | 16 +++++++++-------
 launcher/updater/PrismExternalUpdater.h   |  2 +-
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/launcher/updater/PrismExternalUpdater.cpp b/launcher/updater/PrismExternalUpdater.cpp
index 79714cc35..ea086d174 100644
--- a/launcher/updater/PrismExternalUpdater.cpp
+++ b/launcher/updater/PrismExternalUpdater.cpp
@@ -308,18 +308,20 @@ void PrismExternalUpdater::autoCheckTimerFired() const
 void PrismExternalUpdater::offerUpdate(const QString& versionName,
                                        const QString& versionTag,
                                        const QString& releaseNotes,
-                                       const bool ignoreSkipped) const
+                                       const bool triggeredByUser) const
 {
     priv->settings->beginGroup("skip");
-    auto shouldSkip = !ignoreSkipped && priv->settings->value(versionTag, false).toBool();
+    auto shouldSkip = !triggeredByUser && priv->settings->value(versionTag, false).toBool();
     priv->settings->endGroup();
 
     if (shouldSkip) {
-        auto msgBox = QMessageBox(QMessageBox::Information, tr("No Update Available"), tr("There are no new updates available."),
-                                  QMessageBox::Ok, priv->parent);
-        msgBox.setMinimumWidth(460);
-        msgBox.adjustSize();
-        msgBox.exec();
+        if (triggeredByUser) {
+            auto msgBox = QMessageBox(QMessageBox::Information, tr("No Update Available"), tr("There are no new updates available."),
+                                      QMessageBox::Ok, priv->parent);
+            msgBox.setMinimumWidth(460);
+            msgBox.adjustSize();
+            msgBox.exec();
+        }
         return;
     }
 
diff --git a/launcher/updater/PrismExternalUpdater.h b/launcher/updater/PrismExternalUpdater.h
index 9b0b25fbb..b3f284b33 100644
--- a/launcher/updater/PrismExternalUpdater.h
+++ b/launcher/updater/PrismExternalUpdater.h
@@ -81,7 +81,7 @@ class PrismExternalUpdater : public ExternalUpdater {
     void disconnectTimer();
     void connectTimer();
 
-    void offerUpdate(const QString& versionName, const QString& versionTag, const QString& releaseNotes, bool ignoreSkipped) const;
+    void offerUpdate(const QString& versionName, const QString& versionTag, const QString& releaseNotes, bool triggeredByUser) const;
     void performUpdate(const QString& versionTag) const;
 
    public slots: