mc-in-work/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2026-06-29 01:54:20 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor(Application.h): reduce include chain

Browse source 
Include only what's absolutely necessary to reduce headers pulled into a
translation unit. If you need access to
instance's from `APPLICATION` include `BaseInstance.h` separately

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
This commit is contained in:
Rachel Powers 2025-12-15 15:10:04 -07:00
parent 35121f26fd
commit 0ba2c09787
No known key found for this signature in database
GPG key ID: B4CB507E51F8B89C
6 changed files with 21 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
launcher/Application.h
View file

@ -37,6 +37,8 @@
#pragma once #pragma once
#include <memory>
#include <QApplication> #include <QApplication>
#include <QDateTime> #include <QDateTime>
#include <QDebug> #include <QDebug>
@ -44,12 +46,12 @@
#include <QIcon> #include <QIcon>
#include <QMutex> #include <QMutex>
#include <QUrl> #include <QUrl>
#include <memory>
#include <BaseInstance.h> #include "QObjectPtr.h"
#include "launch/LogModel.h" #include "launch/LogModel.h"
#include "minecraft/launch/MinecraftTarget.h" #include "minecraft/auth/MinecraftAccount.h"
#include "settings/SettingsObject.h"
class LaunchController; class LaunchController;
class LocalPeer; class LocalPeer;
@ -74,6 +76,13 @@ class ITheme;
class MCEditTool; class MCEditTool;
class ThemeManager; class ThemeManager;
class IconTheme; class IconTheme;
class BaseInstance;
struct MinecraftTarget;
// pointers for lazy people
using InstancePtr = std::shared_ptr<BaseInstance>;
using MinecraftTargetPtr = std::shared_ptr<MinecraftTarget>;
namespace Meta { namespace Meta {
class Index; class Index;
@ -212,7 +221,7 @@ class Application : public QApplication {
bool launch(BaseInstance* instance, bool launch(BaseInstance* instance,
bool online = true, bool online = true,
bool demo = false, bool demo = false,
MinecraftTarget::Ptr targetToJoin = nullptr, MinecraftTargetPtr targetToJoin = nullptr,
MinecraftAccountPtr accountToUse = nullptr, MinecraftAccountPtr accountToUse = nullptr,
const QString& offlineName = QString()); const QString& offlineName = QString());
bool kill(BaseInstance* instance); bool kill(BaseInstance* instance);

1
launcher/include/base.pch.hpp
View file

@ -3,6 +3,7 @@
#define PRISM_PRECOMPILED_BASE_HEADERS_H #define PRISM_PRECOMPILED_BASE_HEADERS_H
#include <algorithm> #include <algorithm>
#include <cstddef>
#include <functional> #include <functional>
#include <memory> #include <memory>
#include <optional> #include <optional>

6
launcher/include/qtcore.pch.hpp
View file

@ -5,9 +5,15 @@
#include <QEvent> #include <QEvent>
#include <QMetaType> #include <QMetaType>
#include <QObject> #include <QObject>
#include <QPointer>
#include <QSharedPointer>
#include <QVariant> #include <QVariant>
#include <QVariantMap>
#include <QDebug> #include <QDebug>
#include <QLoggingCategory>
#include <QCoreApplication> #include <QCoreApplication>

1
launcher/minecraft/ShortcutUtils.h
View file

@ -37,6 +37,7 @@
#pragma once #pragma once
#include "Application.h" #include "Application.h"
#include "BaseInstance.h"
#include <QList> #include <QList>
#include <QMessageBox> #include <QMessageBox>

1
launcher/minecraft/auth/AuthFlow.h
View file

@ -2,7 +2,6 @@
#include <QImage> #include <QImage>
#include <QList> #include <QList>
#include <QNetworkReply>
#include <QObject> #include <QObject>
#include <QSet> #include <QSet>

1
launcher/minecraft/auth/AuthStep.h
View file

@ -1,6 +1,5 @@
#pragma once #pragma once
#include <QList> #include <QList>
#include <QNetworkReply>
#include <QObject> #include <QObject>
#include "QObjectPtr.h" #include "QObjectPtr.h"