From 067a9923782416202940fde3dc0ab8ff1c295795 Mon Sep 17 00:00:00 2001 From: Seth Flynn Date: Sat, 7 Mar 2026 03:25:25 -0500 Subject: [PATCH] ci(clang-tidy): disable pch This would previously make most of our files error out with `error: __OPTIMIZE__ predefined macro was enabled in PCH file but is currently disabled` Signed-off-by: Seth Flynn --- .github/workflows/clang-tidy.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/clang-tidy.yml b/.github/workflows/clang-tidy.yml index 75601853a..0d9fe85ff 100644 --- a/.github/workflows/clang-tidy.yml +++ b/.github/workflows/clang-tidy.yml @@ -37,9 +37,10 @@ jobs: uses: cachix/install-nix-action@v31 - name: Run build + # TODO(@getchoo): Figure out how to make this work with PCH run: | nix develop --command bash -c ' - cmake -B build -D CMAKE_CXX_COMPILER_LAUNCHER=sccache && cmake --build build + cmake -B build -D Launcher_USE_PCH=OFF -D CMAKE_CXX_COMPILER_LAUNCHER=sccache && cmake --build build ' # TODO: Use SARIF after https://github.com/psastras/sarif-rs/issues/638 is fixed